Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
temp+fix: Fix/10812 redundant source map upload (#11993)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR introduces two new workflows in Bitrise - `build_android_release_and_upload_sourcemaps` - Runs `build_android_release` and uploads sourcemaps to Sentry - `build_ios_release_and_upload_sourcemaps` - Runs `build_ios_release` and uploads sourcemaps to Sentry By default, both `build_android_release` and `build_ios_release` will not automatically upload sourcemaps to Sentry Related PR - #11490 ## **Related issues** Fixes: #10812 ## **Manual testing steps** To build release AND upload sourcemaps, use the two workflows in Bitrise: - `build_android_release_and_upload_sourcemaps` - `build_ios_release_and_upload_sourcemaps` To only build release without uploading sourcemaps, use the two workflows in Bitrise: - `build_android_release` - `build_ios_release` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> In this test, we ran the default `build_ios_release` and `build_android_release`, which resulted in no sourcemaps being uploaded - Android - https://app.bitrise.io/build/bc568645-d1e4-418c-bea0-6aafe8f2e21c - iOS - https://app.bitrise.io/build/e7c224b3-c0f3-4be9-afa0-b3ad423d0da7 In this test, we enabled Sentry sourcemap upload and re-used `build_ios_release` and `build_android_release` to mimic the workflows that uploads sourcemaps. We can see in the two builds that it successfully uploads sourcemaps. - Android - https://app.bitrise.io/build/d93989e0-3ca8-4bab-aaf2-48b0ca104986 - iOS - https://app.bitrise.io/build/b24edfed-b020-4ac1-bf44-191d284b099b Sourcemaps uploaded - Android: <img width="870" alt="Screenshot 2024-10-23 at 6 08 21 PM" src="https://github.com/user-attachments/assets/44b24050-7337-4cc8-b13a-5aa9795bb72d"> - iOS: <img width="851" alt="Screenshot 2024-10-23 at 6 08 31 PM" src="https://github.com/user-attachments/assets/c26e8b8c-a767-46ee-ade6-5c519767893c"> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information