Skip to content

Commit

Permalink
feat: Signature Controller v5.3.1 (#8989)
Browse files Browse the repository at this point in the history
Minor update of signature controller to 5.3.1, signature controller on
this version have the approval controller as a dependency on versino
3.5.1 that we do not have yet on mobile, with this being said,
everything seems to be working but it is better to ship this updates
together for we have the dependencies aligned

This is the issue that updates approval controller:
MetaMask/mobile-planning#1604

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

Exploratory signs with E2E test dapp and send transaction o sepolia:
https://recordit.co/69lqoJGUag

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
tommasini authored Mar 21, 2024
1 parent f031748 commit 142e0f4
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 20 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
"@metamask/react-native-button": "^3.0.0",
"@metamask/scure-bip39": "^2.1.0",
"@metamask/sdk-communication-layer": "^0.12.0",
"@metamask/signature-controller": "5.3.0",
"@metamask/signature-controller": "5.3.1",
"@metamask/slip44": "3.1.0",
"@metamask/snaps-controllers": "^5.0.0",
"@metamask/snaps-rpc-methods": "^6.0.0",
Expand Down
37 changes: 18 additions & 19 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3749,17 +3749,17 @@
ethereumjs-util "^7.0.10"
fast-deep-equal "^3.1.3"

"@metamask/controller-utils@^8.0.1", "@metamask/controller-utils@^8.0.2":
version "8.0.3"
resolved "https://registry.yarnpkg.com/@metamask/controller-utils/-/controller-utils-8.0.3.tgz#b27e4ba5f579ab59bf49174aae652fec41652337"
integrity sha512-a1rxrBcu4rSqeSuH3vUIYA7fK8ZLnogxMOTk19Q86fOhuYN/p2CDwgxdr3RrZtDgyVEe5RJ38TSXiPI8Nh5g6A==
"@metamask/controller-utils@^8.0.1", "@metamask/controller-utils@^8.0.2", "@metamask/controller-utils@^8.0.4":
version "8.0.4"
resolved "https://registry.yarnpkg.com/@metamask/controller-utils/-/controller-utils-8.0.4.tgz#78a952301ff4b2a501b31865ab0de434c6ea3cd2"
integrity sha512-R0+Q5ROnXKTtxAmiCH4TYHkGfbZTT8qzLeycJQVeJHXhpeYlAPxjs8m5fy1jwW1tX4r0MDWShx9iNUmHZS41jw==
dependencies:
"@ethereumjs/util" "^8.1.0"
"@metamask/eth-query" "^4.0.0"
"@metamask/ethjs-unit" "^0.3.0"
"@metamask/utils" "^8.3.0"
"@spruceid/siwe-parser" "1.1.3"
eth-ens-namehash "^2.0.8"
ethereumjs-util "^7.0.10"
fast-deep-equal "^3.1.3"

"@metamask/controllers@^26.0.0":
Expand Down Expand Up @@ -4067,17 +4067,16 @@
"@metamask/controller-utils" "^4.3.2"
uuid "^8.3.2"

"@metamask/message-manager@^7.2.0", "@metamask/message-manager@^7.3.5":
version "7.3.8"
resolved "https://registry.yarnpkg.com/@metamask/message-manager/-/message-manager-7.3.8.tgz#c47f60b4cfc7404c7fa463656f0553e0bc38cd27"
integrity sha512-Dfzj6WtzNLrjj+j/pMO6XtdbwvGxvCj5ZjTzyR2zOIp0pZS6tiNbPO+iLlZXxpOH5OYVlBq3K2eR/IGur21LxA==
"@metamask/message-manager@^7.3.1", "@metamask/message-manager@^7.3.5":
version "7.3.9"
resolved "https://registry.yarnpkg.com/@metamask/message-manager/-/message-manager-7.3.9.tgz#4d416998bbdda30d80ebbb50b5efc7475b816ec9"
integrity sha512-B0+Qa1bPGMuVdBDaq8zcAKkRXWAt1CYAXW2NXzfO85a2ePFCUIrIhF9W8LflatXDXqesE5Y8Dij0sHGmsUfF8w==
dependencies:
"@metamask/base-controller" "^4.1.1"
"@metamask/controller-utils" "^8.0.2"
"@metamask/controller-utils" "^8.0.4"
"@metamask/eth-sig-util" "^7.0.1"
"@metamask/utils" "^8.3.0"
"@types/uuid" "^8.3.0"
ethereumjs-util "^7.0.10"
jsonschema "^1.2.4"
uuid "^8.3.2"

Expand Down Expand Up @@ -4372,15 +4371,15 @@
socket.io-client "^4.5.1"
uuid "^8.3.2"

"@metamask/[email protected].0":
version "5.3.0"
resolved "https://registry.yarnpkg.com/@metamask/signature-controller/-/signature-controller-5.3.0.tgz#d72a447be4a89a097329a73ef7608ceb939cd920"
integrity sha512-R3Hcg6l7ecqdkNxKUg5IWSqw/mLWDj2+2E2ZYJ74MorLwxjMsATak5Q4gEhKGesvNu9y9g5UP+Zje43G5fw/0g==
"@metamask/[email protected].1":
version "5.3.1"
resolved "https://registry.yarnpkg.com/@metamask/signature-controller/-/signature-controller-5.3.1.tgz#1a55b7b60435f0bbf74c54fbcfa42bcada0a8450"
integrity sha512-BCmocdIlSsxDguLwawGQpaq5rY1OLVGyDnB1JS6ubiyympTWUVGC7bTXg2hDoPWBZgRNSC4H8gEMZqg+J/0i0w==
dependencies:
"@metamask/approval-controller" "^3.5.0"
"@metamask/base-controller" "^3.2.0"
"@metamask/controller-utils" "^4.3.0"
"@metamask/message-manager" "^7.2.0"
"@metamask/approval-controller" "^3.5.1"
"@metamask/base-controller" "^3.2.1"
"@metamask/controller-utils" "^4.3.2"
"@metamask/message-manager" "^7.3.1"
"@metamask/utils" "^6.2.0"
eth-rpc-errors "^4.0.2"
ethereumjs-util "^7.0.10"
Expand Down

0 comments on commit 142e0f4

Please sign in to comment.