fix: Update STX Banner Alert, include chainSupportsSmartTransactions & STX liveness check
#29911
+152
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…STX liveness checks. - Added imports for feature flag and STX liveness checks - Added Redux dispatch hook - Added selectors for chain support and preference enabled - Added useEffect to fetch feature flags and STX liveness when alert is enabled - Updated alertConditions to include chain support and preference enabled checks The banner will now wait for feature flags and STX liveness to be fetched before potentially rendering, and will only show if the chain supports smart transactions and they are enabled in preferences.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updates test state structure to match production selectors: - Integrated `mockNetworkState` helper for network configuration WAS KEY - Added required `swapsState` structure (`extensionActive`, `smartTransactions config`) - Fixes `preference-disabled` tests w/ complete feat flag state The `swapsState` configuration contains essential settings that control how smart transactions behave Adding `swapsState` was needed to match network-specific MetaMask smart transaction settings, including extension state and transaction params These settings determine feature availability and transaction behavior across different platforms and networks
Changes: - `135.ts` - Updated migration script to only `set smartTransactionsMigrationApplied` when STX is newly enabled - `135.test.ts` - Updated tests to verify migration behavior with clearer test descriptions `transaction-alerts.test.js` - Updated test to properly mock network configuration for the banner component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…STX liveness checks.
The banner will now wait for feature flags and STX liveness to be fetched before potentially rendering, and will only show if the chain supports smart transactions and they are enabled in preferences.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist