Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure user traits set before opting in to participate in metametrics… #29871

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Jan 23, 2025

… get properly updated upon participate in metametrics

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

… get properly updated upon participate in metametrics
@metamaskbot
Copy link
Collaborator

Builds ready [a7887e3]
Page Load Metrics (1721 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14922010172217684
domContentLoaded14761994169817584
load14882017172117986
domInteractive246939136
backgroundConnect86622136
firstReactRender1576382311
getState55818199
initialActions01000
loadScripts10281506124714670
setupStore55612147
uiStartup16672296197520196
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 56 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants