Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade transaction controller to get incoming transactions using accounts API #28597

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

matthewwalsh0
Copy link
Member

@matthewwalsh0 matthewwalsh0 commented Nov 21, 2024

Description

Update @metamask/transaction-controller to retrieve incoming transactions using the accounts API rather than Etherscan.

Open in GitHub Codespaces

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Use preview build.
@matthewwalsh0 matthewwalsh0 added the team-confirmations Push issues to confirmations team label Nov 21, 2024
Add queryEntireHistory and updateTransaction options.
Revert state rename.
Add E2E tests.
Copy link

socket-security bot commented Nov 22, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@metamaskbot
Copy link
Collaborator

Builds ready [a0c9c3f]
Page Load Metrics (1815 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15712169182514469
domContentLoaded15612148177414167
load15702171181514570
domInteractive22159453014
backgroundConnect11159393718
firstReactRender743831357837
getState588262613
initialActions01000
loadScripts11131559129511053
setupStore68612178
uiStartup175725832080249120
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 222 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -5.82 KiB (-0.07%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants