Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(json-rpc-engine): @metamask/rpc-errors@^6.3.1->^7.0.0 #4773

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

deps(json-rpc-engine): @metamask/rpc-errors@^6.3.1->^7.0.0 #4773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b88b27
deps(json-rpc-engine): @metamask/rpc-errors@^6.3.1->^7.0.0
legobeat Oct 9, 2024
7849aff
chore: allow exception for @metamask/rpc-errors@^7.0.0 inconsistent d…
legobeat Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/json-rpc-engine/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
},
"dependencies": {
"@metamask/rpc-errors": "^6.3.1",
"@metamask/rpc-errors": "^7.0.0",
"@metamask/safe-event-emitter": "^3.0.0",
"@metamask/utils": "^9.1.0"
},
Expand Down
7 changes: 4 additions & 3 deletions yarn.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,10 @@ function expectControllerDependenciesListedAsPeerDependencies(
}
}

const ALLOWED_INCONSISTENT_DEPENDENCIES = Object.entries({
'@metamask/rpc-errors': ['^7.0.0'],
});

/**
* Filter out dependency ranges which are not to be considered in `expectConsistentDependenciesAndDevDependencies`.
*
Expand All @@ -725,9 +729,6 @@ function getInconsistentDependenciesAndDevDependencies(
dependencyIdent,
dependenciesByRange,
) {
const ALLOWED_INCONSISTENT_DEPENDENCIES = Object.entries({
// '@metamask/foo': ['^1.0.0'],
});
for (const [
allowedPackage,
ignoredRange,
Expand Down
12 changes: 11 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2862,7 +2862,7 @@ __metadata:
dependencies:
"@lavamoat/allow-scripts": "npm:^3.0.4"
"@metamask/auto-changelog": "npm:^3.4.4"
"@metamask/rpc-errors": "npm:^6.3.1"
"@metamask/rpc-errors": "npm:^7.0.0"
"@metamask/safe-event-emitter": "npm:^3.0.0"
"@metamask/utils": "npm:^9.1.0"
"@types/jest": "npm:^27.4.1"
Expand Down Expand Up @@ -3403,6 +3403,16 @@ __metadata:
languageName: node
linkType: hard

"@metamask/rpc-errors@npm:^7.0.0":
version: 7.0.0
resolution: "@metamask/rpc-errors@npm:7.0.0"
dependencies:
"@metamask/utils": "npm:^9.0.0"
fast-safe-stringify: "npm:^2.0.6"
checksum: 10/f25e2a5506d4d0d6193c88aef8f035ec189a1177f8aee8fa01c9a33d73b1536ca7b5eea2fb33a477768bbd2abaf16529e68f0b3cf714387e5d6c9178225354fd
languageName: node
linkType: hard

"@metamask/safe-event-emitter@npm:^3.0.0, @metamask/safe-event-emitter@npm:^3.1.1":
version: 3.1.1
resolution: "@metamask/safe-event-emitter@npm:3.1.1"
Expand Down
Loading