chore(constraints): allow exceptions for dependency-range consistency #4772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legobeat
force-pushed
the
constraints-allow-consistent-dependency-ranges-exception
branch
from
8be8f73
to
d7c7bd1
Compare
This was referenced Oct 9, 2024
legobeat
changed the title
legobeat
force-pushed
the
constraints-allow-consistent-dependency-ranges-exception
branch
from
d7c7bd1
to
4502883
Compare
6 tasks
legobeat
force-pushed
the
constraints-allow-consistent-dependency-ranges-exception
branch
from
ae521de
to
f23be0c
Compare
legobeat
requested review from
Gudahtt,
MajorLift,
Mrtenz and
Prithpal-Sooriya
Mrtenz
reviewed
Oct 9, 2024
Comment on lines
+728
to
+730
| const ALLOWED_INCONSISTENT_DEPENDENCIES = Object.entries({ | ||
| // '@metamask/foo': ['^1.0.0'], | ||
| }); |
There was a problem hiding this comment.
Should this be near the top of the file?
There was a problem hiding this comment.
I'm thinking co-locating is clearer (esp since other exceptions are also currently inlined) but I will move it out of the function body in a follow-up!
There was a problem hiding this comment.
Mrtenz
approved these changes
Oct 9, 2024
legobeat
deleted the
constraints-allow-consistent-dependency-ranges-exception
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This allows adding explicit exceptions for the Yarn constraint
expectConsistentDependenciesAndDevDependencies.An exception entry consists of a package name and a set of exact version ranges to be ignored in checking.
This is useful when we have "repo-circular" dependencies, where package A (in this repo) depends on package B (in another repo), which in its turn depends on package C (back again in this repo), finally depending on some package D.
In some cases, bumping D atomically in the monorepo makes things very heavy-handed. This change allows to slice it up in such situations.
References
C = @metamask/json-rpc-engineD = @metamask/rpc-errorsChangelog
None
Checklist