Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCKAN-74 Modify loader with the one designed + add title under the loading bar #68

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

dvcorreia
Copy link
Member

Figma design

Current changes:

  1. Circular loaders was replaced by linear progress
  2. Linear progress's progress's follows the isLoading logic as a % of the conditions evaluated to true
  3. SVG logo was added (both Sya and Sara told me that there was not GIF, so I used the figma SVG)
  4. All dimensions match the ones provided in the figma design
export-seg.mp4

@dvcorreia dvcorreia self-assigned this Nov 15, 2024
@dvcorreia dvcorreia requested a review from ddelpiano November 15, 2024 16:36
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddelpiano ddelpiano merged commit b995873 into develop Nov 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants