Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sfn changes #62

Merged
merged 13 commits into from
Nov 12, 2024
Merged

Feature/sfn changes #62

merged 13 commits into from
Nov 12, 2024

Conversation

ddelpiano
Copy link
Member

  • removed empty fields from connection details
  • changed the matrix to express all the origins of the cluster clicked
  • changed the format to avoid the pdf table to be cut (this might require another change imho and go to a bigger format).

@D-GopalKrishna
Copy link

Looks okay, thanks @ddelpiano!

Suggestion: However, if we don't want the page to always be A0 size, I think one potential solution could be to check the number of columns and then assign the page size accordingly.

@D-GopalKrishna
Copy link

thanks @ddelpiano ! Looks good.

@ddelpiano ddelpiano merged commit c210435 into develop Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants