Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESCKAN fix: Move phenotype colormap to context #30

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented May 31, 2024

Disclaimer: To facilitate the review this PR targets feature/formatter. It can be changed to target to develop as soon as #31 is merged

closes https://metacell.atlassian.net/browse/ESCKAN-54

  • Moves phenotype color map to context
  • Uses chroma.js to define the phenotype colors
2024-05-31.15-42-41.mp4
  • Sorts the hierarchical nodes by natural order:
    image

@afonsobspinto afonsobspinto changed the base branch from develop to feature/formatter May 31, 2024 14:52
@afonsobspinto afonsobspinto marked this pull request as ready for review May 31, 2024 14:53
@afonsobspinto afonsobspinto mentioned this pull request May 31, 2024
Copy link
Member

@ddelpiano ddelpiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ddelpiano ddelpiano merged commit b2e2821 into feature/formatter Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants