-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/esckan-43 - connect Summary Filters #27
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
342eff1
ESCKAN-43 minor types update
D-GopalKrishna 5831658
ESCKAN-43 - integrate summary filters
D-GopalKrishna 07b9f46
ESCKAN-43 cleanup
D-GopalKrishna 22ba408
ESCKAN-43 shift "other" constant to settings.ts
D-GopalKrishna fa73c77
Merge branch 'feature/ESCKAN-20-new' into feature/ESCKAN-43
D-GopalKrishna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,85 @@ | ||
import { useMemo } from "react"; | ||
import { SummaryFilters, useDataContext } from "../context/DataContext"; | ||
import CustomFilterDropdown from "./common/CustomFilterDropdown"; | ||
import { Option, PhenotypeDetail } from "./common/Types"; | ||
import { Box } from "@mui/material"; | ||
import { searchNerveFilter, searchPhenotypeFilter } from "../services/searchService"; | ||
import { OTHER_LABEL } from "../constants"; | ||
|
||
interface FilterConfig { | ||
id: keyof SummaryFilters; | ||
placeholder: string; | ||
searchPlaceholder: string; | ||
} | ||
|
||
const filterConfig: FilterConfig[] = [ | ||
{ | ||
id: "Phenotype", | ||
placeholder: "Phenotype", | ||
searchPlaceholder: "Search phenotype", | ||
}, | ||
{ | ||
id: "Nerve", | ||
placeholder: "Nerve", | ||
searchPlaceholder: "Search Nerve", | ||
} | ||
] | ||
|
||
const SummaryFiltersDropdown = ({ nerves, phenotypes }: { | ||
nerves: { [key: string]: string }, | ||
phenotypes: PhenotypeDetail[] | ||
}) => { | ||
const { summaryFilters, setSummaryFilters } = useDataContext(); | ||
|
||
const convertNervesToOptions = (nerves: { [key: string]: string }): Option[] => { | ||
return Object.keys(nerves).map(nerve => ({ | ||
id: nerve, | ||
label: nerves[nerve], | ||
group: 'Nerve', | ||
content: [] | ||
})); | ||
} | ||
const convertPhenotypesToOptions = (phenotypes: PhenotypeDetail[]): Option[] => { | ||
// filter the phenotype where label is other | ||
return phenotypes.map(phenotype => ({ | ||
id: phenotype.label, | ||
label: phenotype.label, | ||
group: 'Phenotype', | ||
content: [] | ||
})).filter(phenotype => phenotype.label !== OTHER_LABEL); | ||
} | ||
|
||
const phenotypeOptions = useMemo(() => convertPhenotypesToOptions(phenotypes), [phenotypes]); | ||
const nerveOptions = useMemo(() => convertNervesToOptions(nerves), [nerves]); | ||
|
||
const handleSelect = (filterKey: keyof typeof summaryFilters, selectedOptions: Option[]) => { | ||
setSummaryFilters(prevFilters => ({ | ||
...prevFilters, | ||
[filterKey]: selectedOptions | ||
})); | ||
}; | ||
|
||
const searchFunctions = { | ||
Phenotype: (value: string) => searchPhenotypeFilter(value, phenotypeOptions), | ||
Nerve: (value: string) => searchNerveFilter(value, nerveOptions) | ||
}; | ||
|
||
return ( | ||
<Box display="flex" gap={1} flexWrap="wrap"> | ||
{filterConfig.map(filter => ( | ||
<CustomFilterDropdown | ||
key={filter.id} | ||
id={filter.id} | ||
placeholder={filter.placeholder} | ||
searchPlaceholder={filter.searchPlaceholder} | ||
selectedOptions={summaryFilters[filter.id]} | ||
onSearch={(searchValue: string) => searchFunctions[filter.id](searchValue)} | ||
onSelect={(options: Option[]) => handleSelect(filter.id as keyof SummaryFilters, options)} | ||
/> | ||
))} | ||
</Box> | ||
) | ||
|
||
} | ||
|
||
export default SummaryFiltersDropdown; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export const OTHER_LABEL = 'other' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: even though the connections/KS may have vias it may not be filtered through them. Since filters shown in the dropdown are only MAJOR NERVES. This can be seen in the video above in PR description.
cc @afonsobspinto @ddelpiano