-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCKAN-287 Update Automated tests #366
Conversation
@ddelpiano there seem to be issues on the sckan-qa pipeline that used to run the tests. Should I also check that? |
@ddelpiano Fixed the qa pipeline so now it runs the tests in dev https://g.codefresh.io/build/675ac2f6a41d4993c76ac430?activeAccountId=5ad732423645ac000112d7de |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimaoBolota-MetaCell I can see there have been changes to the package.json, could you please separate the testing dependencies in another package.json to keep in the test folder please?
I prefer do not impact the application dependencies for testing updates or upgrades we want to do with the libraries used for QA, and so separate them will keep them indipendent. Thanks.
@@ -25,6 +25,7 @@ | |||
# SECURITY WARNING: don't run with debug turned on in production! | |||
PRODUCTION = os.environ.get("PRODUCTION", "False").lower() in ("true", "1") | |||
USE_PG = os.environ.get("USE_PG", "False").lower() in ("true", "1") | |||
TESTING = os.environ.get("TESTING", "False").lower() in ("true", "1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: