Feature/sckan 333 #360
Merged
Feature/sckan 333 #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D-GopalKrishna
commented
Nov 22, 2024
backend/composer/api/filtersets.py
Outdated
| Q(user=system_user, note__icontains="exported") | | ||
| ~Q(user=system_user) | ||
| ~Q(user=system_user)) & | ||
| ~Q(type__in=[NoteType.TRANSITION]) |
There was a problem hiding this comment.
This allows us to - not show any transition related notes by default
ddelpiano
approved these changes
Nov 26, 2024
|
@D-GopalKrishna an issue here - the export transition should show up as per acceptance criteria scrnli_XAuCM5d7WaQ1mi.webm |
ddelpiano
requested changes
Nov 26, 2024
- to include invalid and exported transitions
|
thanks @ddelpiano ! Updated it - by removing the logic to - not include the transition notes. 2024-11-26.16-02-20.mp4 |
ddelpiano
approved these changes
Nov 26, 2024
afonsobspinto
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira link - SCKAN-333
About task:
demo video
Screencast from 11-17-2024 03:26:57 PM.webm