Feature/sckan-312 - add flag to neurondm ingestion script to disable the overwrite of KSs #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep the defaults, if not provided manually
…nd_new_statements
D-GopalKrishna
commented
Oct 11, 2024
backend/composer/services/cs_ingestion/helpers/overwritable_helper.py
Outdated
Show resolved
Hide resolved
afonsobspinto
requested changes
Oct 11, 2024
backend/composer/services/cs_ingestion/helpers/overwritable_helper.py
Outdated
Show resolved
Hide resolved
backend/composer/services/cs_ingestion/helpers/overwritable_helper.py
Outdated
Show resolved
Hide resolved
D-GopalKrishna
dismissed
ddelpiano’s stale review
The base branch was changed.
afonsobspinto
previously approved these changes
Oct 14, 2024
ddelpiano
requested changes
Oct 17, 2024
|
@D-GopalKrishna both 311 and 312 are good for me, the only thing I would like to see are tests for both the features. Thanks a lot and great work :) |
|
NOTE: added tests. This increases the time to run the tests significantly - from literally under 1s to more than 400s. |
afonsobspinto
previously approved these changes
Oct 31, 2024
afonsobspinto
approved these changes
Nov 5, 2024
ddelpiano
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Link - SCKAN-312
Task description:
More on the previous vs updated logic:
After the changes the definition of
overwritable_and_new_statementschanges. Whether the statements are overwritable or not depends on two utils -has_invalid_sentenceandhas_invalid_sentence.(Previously and now) if the statement/sentence didn't exist we say it's not invalid. And therefore overwritable (new statement/sentence). This logic stays the same.
Previously - if the statement/sentence exists, and was overwritable (depending on if it is invalid/exported/compose_now) - then it is not invalid, and hence overwritable.
Now (after the change) - WE ONLY CHANGE THIS LOGIC above. This check only happens --disable_overwrite flag is not passed. If the flag is passed - we do not check this, and say the statement/sentence is invalid and hence - not overwritable.
Short demo video to showcase the same.
2024-10-11.14-26-48.mp4
demo after the logic is enabled.
2024-10-11.14-34-30.mp4