SCKAN-274 feat: Update deduplicate_anatomical_entities migration stra… #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsobspinto
force-pushed
the
feature/SCKAN-274
branch
from
267b38d to
b063852
Compare
afonsobspinto
force-pushed
the
feature/SCKAN-274
branch
from
b063852 to
358e8ab
Compare
|
I noticed some inconsistent results when testing, so I'm moving it back to a draft |
|
On top of that, the original implementation was taking me around 5 minutes to complete. |
|
Closing since the @zsinnema made the pipeline pass 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still took me around 12 minutes to run the migration locally.