Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sckan 248 b #221

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Feature/sckan 248 b #221

merged 3 commits into from
Feb 9, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented Feb 9, 2024

closes https://metacell.atlassian.net/browse/SCKAN-248

  • Updates ingestion log file names and better formats the content
  • Updates validation error messages for the neurondm inconsistencies (axioms validation now show the difference instead of the whole sets; axioms not found for entities now show a treated string instead of a orders.rl object)
  • Fixes neuronDM version
  • Adds time measurement to ingestion command

image

@zsinnema
Copy link
Contributor

zsinnema commented Feb 9, 2024

@afonsobspinto can you please fix the failing check? thanks :-) !

@afonsobspinto
Copy link
Member Author

Linting problems are not coming from the current changes but they are rather present in develop already. I spoke with @Salam-Dalloul and she will fix them in one of her PR's.

@zsinnema zsinnema merged commit 0ff5996 into develop Feb 9, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants