SCKAN-262: fix UI crash for button menu #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salam-Dalloul
previously approved these changes
Feb 9, 2024
| @@ -40,6 +40,7 @@ export default function GroupedButtons({handleClick, selectedOption, options, se | |||
| aria-label="select merge strategy" | |||
| aria-haspopup="menu" | |||
| onClick={handleToggle} | |||
| disabled={options?.length > 0 ? false : true} | |||
There was a problem hiding this comment.
hey @ddelpiano i only have one suggestion here to make the button looks better, for now it looks like this
if we just make an edit for the options passed value to have an initial value as an empty array if it's undefined in here
export default function GroupedButtons({handleClick, selectedOption, options = [], selectedIndex, handleMenuItemClick , hasFormat = false, format, isDisabled}: any) {
and then add the disabled state for ButtonGroup not the Arrow button
<ButtonGroup variant="contained" ref={anchorRef} disabled={options.length === 0 || isDisabled}>
then the button when looks like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.