Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/13, 14 - Add theme to meta-diagram, fix the example to use the same. #15

Merged
merged 5 commits into from
Jul 22, 2022

Conversation

vidhya-metacell
Copy link
Contributor

Closes #13 #14

@vidhya-metacell vidhya-metacell self-assigned this Jul 21, 2022
@vidhya-metacell vidhya-metacell requested a review from zsinnema July 21, 2022 13:47
Copy link
Member

@afonsobspinto afonsobspinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like @ddelpiano 's suggestion to merge the theme props. Besides that I'm good

@vidhya-metacell
Copy link
Contributor Author

I like @ddelpiano 's suggestion to merge the theme props. Besides that I'm good

@afonsobspinto yea i added the change for that

@vidhya-metacell
Copy link
Contributor Author

@zsinnema could you please merge this one.

@zsinnema zsinnema merged commit 7b968c7 into develop Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants