Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/client feedback #55

Merged
merged 6 commits into from
May 14, 2024
Merged

Feature/client feedback #55

merged 6 commits into from
May 14, 2024

Conversation

afonsobspinto
Copy link
Member

@afonsobspinto afonsobspinto commented May 14, 2024

Fixes:

The abbreviation is not meaningful for users. E.g. Sex t_cde_0369384.
When an abbreviation is correctly annotated for the CDE it displays correctly
If not found it currently displays a mashup including the ID. Perhaps just leave it blank

For the right hand selector - the title is more appropriate for display for selection

When mapping, it would be nice for unmapped terms to automatically populate the search part of "Choose CDE or Data Dictionary fields…” with the column heading

When choosing or clicking on a term in the search list - the drop down should close automatically.

  • Allows search on custom dictionary fields already present in the initial dataset mapping provided
  • Update search placeholder logic
2024-05-14.12-52-53.mp4

@afonsobspinto afonsobspinto requested a review from ddelpiano May 14, 2024 11:49
@afonsobspinto afonsobspinto force-pushed the feature/client-feedback branch from 751c56f to 6ae8655 Compare May 14, 2024 11:52
@afonsobspinto afonsobspinto marked this pull request as draft May 14, 2024 12:04
@afonsobspinto afonsobspinto marked this pull request as ready for review May 14, 2024 12:18
@ddelpiano ddelpiano merged commit bd3ddac into develop May 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants