New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDE-74 fix: Use useMemo for additionalDatasetMappings calculation #45

Merged

zsinnema merged 1 commit into develop from feature/CDE-74

Apr 23, 2024

Member

afonsobspinto commented Apr 17, 2024

Closes https://metacell.atlassian.net/browse/CDE-74

The non-use of useMemo in the calculation of additionalDatasetMappings was triggering the suggestions recalculation which was retriggering the creation of the functions defined in the ServiceProvider which, finally, was retriggering the useEffect in the SuggestionsStep component that is responsible to set the initial suggestionsToProcess state variable:

2024-04-17.17-23-01.mp4


          CDE-74 fix: Use useMemo for additionalDatasetMappings calculation

f6febc0

afonsobspinto requested a review from zsinnema

April 17, 2024 16:33

zsinnema approved these changes

View reviewed changes

zsinnema merged commit c0ace29 into develop

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet