Feature/cde 65 #35
Merged
Feature/cde 65 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afonsobspinto
force-pushed
the
feature/CDE-65
branch
from
2bb0612 to
bdaeddf
Compare
Merged
zsinnema
approved these changes
Mar 27, 2024
|
@afonsobspinto can you servolve the conflicts? thanks |
* CDE-67 feat: Refactor out chip component * CDE-67 feat: Fix memory leak on optionsMap * CDE-67 feat: WIP - Connect dictionary fields search * CDE-67 fix: Update mapping strategy to rely on header indexes * CDE-67 fix: Disallow variable name overwrite * CDE-67 feat: Add custom dictionary field validation * CDE-67 feat: Add search on previous custom dictionary fields * CDE-67 feat: Update search collection label
|
@afonsobspinto btw I merged #36 into this one :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCLAIMER: The target branch is pointing to feature/CDE-39. It can change to develop when #34 is merged
Closes https://metacell.atlassian.net/browse/CDE-65
CreateCustomDictionaryFieldBody allows the user to fill in all the columns that currently exist in the datasetMapping header (except variable name, id and cde level which are automatically filled). It manages it's own state for immediate updates and updates the parent state onBlur changes
Upon confirmation on the CreateCustomDictionaryFieldHeader, the parent adds the created custom dictionary field as an option and chooses that option for the header in cause.
2024-03-26.11-59-16.mp4
Notes: