-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CELE-116 Frontend changes for the EM viewer #76
Conversation
const { gray50, gray600, gray400B } = vars; | ||
const CustomFormControlLabel = ({ label, tooltipTitle, helpText }) => { | ||
const CustomFormControlLabel = ({ label, tooltipTitle, helpText, checked, onChange }: CustomFormControlLabel) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this somewhere else? It's imported by the EM viewer.
I can also just copy it to the EM viewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I would move it somewhere else instead, if it's shared, it's weird to have it in the 3D viewer only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvcorreia Thanks for the first version 🙏
I think it's important though to use the synchronizers and not to rely on special attributes for the features. The fact that currently there is no "behavior" to synapse selection in the 3D view should be handled (if not already) by just doing nothing, and the nothing should be done in reaction to the synchronization of synapses on the graph view.
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
CELE-116 Frontend changes for the EM viewer (Synchronizers integration)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good overall @dvcorreia ! Thanks a lot 🙏 !
There is only 2/3 small modifications to do, but it's more about js/ts syntax, nothing else.
applications/visualizer/frontend/src/components/viewers/EM/EMStackTilesViewer.tsx
Outdated
Show resolved
Hide resolved
applications/visualizer/frontend/src/components/viewers/EM/SceneControls.tsx
Outdated
Show resolved
Hide resolved
const { gray50, gray600, gray400B } = vars; | ||
const CustomFormControlLabel = ({ label, tooltipTitle, helpText }) => { | ||
const CustomFormControlLabel = ({ label, tooltipTitle, helpText, checked, onChange }: CustomFormControlLabel) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, I would move it somewhere else instead, if it's shared, it's weird to have it in the 3D viewer only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the final modifications 🙏
screen-recording.mp4