CELE-109 Fixes screen flash with 3D viewer #67
Merged
+60
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem of flash came from the fact that, depending on the dataset, the data couldn't be fetch. When that was the case, none of the scene was rendered, even if only one file couldn't be loaded. This commit changes the way the 3D images are loaded, and shows an error message to inform the user if one of the 3D images cannot be displayed (the other images for the requested neurons are displayed if they exists in the bucket).
aranega
force-pushed
the
feature/CELE-109
branch
from
4104800
to
bcdfd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem of flash came from the fact that, depending on the dataset, the data couldn't be fetch. When that was the case, none of the scene was rendered, even if only one file couldn't be loaded. This commit changes the way the 3D images are loaded, and shows an error message to inform the user if one of the 3D images cannot be displayed (the other images for the requested neurons are displayed if they exists in the bucket).