Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#108 update the ambientLight color #65

Merged
merged 1 commit into from
Oct 18, 2024
Merged

#108 update the ambientLight color #65

merged 1 commit into from
Oct 18, 2024

Conversation

Salam-Dalloul
Copy link

No description provided.

@ddelpiano ddelpiano merged commit f899197 into develop Oct 18, 2024
10 checks passed
@@ -101,7 +100,7 @@ function ThreeDViewer() {
/>
<CameraControls ref={cameraControlRef} />

<ambientLight color={LIGHT_1_COLOR} />
<ambientLight color={"0x404040"} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I think it would make more sense to change the value of LIGHT_1_COLOR

@@ -101,7 +100,7 @@ function ThreeDViewer() {
/>
<CameraControls ref={cameraControlRef} />

<ambientLight color={LIGHT_1_COLOR} />
<ambientLight color={"0x404040"} />
<directionalLight color={LIGHT_2_COLOR} position={LIGHT_2_POSITION} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Do we need the directional light?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants