-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue984 flow run refactor (branches from the other polling PR) #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace holder this should work
Probably best to merge the other one, then start this over... because I want a single squash merge for the other one, but in this one, every change is ok (none break the tests.) so it's ok to keep them separate. |
will close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poll can now run download like all the other components... kind of a happy side effect of just refactoring the code to make it easier to understand.
builds on #985
The run() routine is 288 lines ... it is too long to think about. Refactored code chunks into separate routines
just to shorten the code in run() The code didn't change much at all, it is just re-arranged.
Moved:
a work() function as a wrapper for it.
run() is now 159 lines. Changes in behaviour:
This PR includes the PR it is based on since that one isn't merged yet... will see how it goes if the other one gets merged first.