Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue860 4 suppress the default source guess if some other option is specified. And more! #877

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

petersilva
Copy link
Contributor

in rc4 the logic uses "source" if it was set, the idea being that if the option, the expectation being that if it wasn't set, it would not be defined.

unfortunately, the finalize logic in config.py establishes default values for source based on the broker username, or failing that, the post_broker username. since a default value was guessed, "source" is always specified.

This change prevents guessing of source values unless no overriding option is specified.

@petersilva
Copy link
Contributor Author

I'm a bit confused. What I intended to do is:

all three somehow ended up in this PR, and 2/3 are already in development.
I messed up, but not sure how. anyways, they should all be good.

@petersilva petersilva changed the title Issue860 4 suppress the default source guess if some other option is specified. Issue860 4 suppress the default source guess if some other option is specified. And more! Dec 23, 2023
@petersilva
Copy link
Contributor Author

the PR for mqtt just got merged (took three years!) so that patch is now actually useful at some point in the future.

@petersilva petersilva merged commit 5710d0d into development Dec 28, 2023
41 of 70 checks passed
@petersilva petersilva deleted the issue860_4 branch January 8, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants