Issue860 4 suppress the default source guess if some other option is specified. And more! #877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in rc4 the logic uses "source" if it was set, the idea being that if the option, the expectation being that if it wasn't set, it would not be defined.
unfortunately, the finalize logic in config.py establishes default values for source based on the broker username, or failing that, the post_broker username. since a default value was guessed, "source" is always specified.
This change prevents guessing of source values unless no overriding option is specified.