Issue1023 take2 topicCopy fix

[petersilva]

close #1023

• um... again... topicCopy should work now.

[github-actions]

Test Results

248 tests   247 ✅  1m 35s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit bca8bb9.

♻️ This comment has been updated with latest results.

[reidsunderland]

I will do a bit more testing tomorrow.

My initial quick test seems like this is always copying the source message's topic, even with topicCopy False. But I could have done something wrong in my test too.

[petersilva]

OK. I think with this last patch it does what people want.

• if the topicCopy option is set, the inbound topic overrides and is copied to the published message.
• if topicCopy is not set, then it tries to build a normal 'subtopic' ... if it can't it doesn't ... the message just doesn't get a topic or a subtopic...

(with previous patch, when the 'subtopic' could not be built, it forced on topicCopy... which "broke" the use case of interest.)

[reidsunderland]

I posted on Teams, just adding here for proper documentation.

topicCopy works now. But with topicCopy off, the topic that gets posted is v02.post and nothing else. It should be v02.post.data.msc ...

[petersilva]

@reidsunderland I looked over the code again... I think it only gets properly set when it is being published, so the log of the component itself would show what you described... is there a way of looking at the next component in the chain ... a subscriber to what was posted? I have the feeling it is published with a good topic, but it will show that truncated one within the component.

[petersilva]

The topic is only properly set on publish... based on the relPath.