Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1064 by adding try/except #1065

Merged
merged 4 commits into from
May 24, 2024
Merged

Fix #1064 by adding try/except #1065

merged 4 commits into from
May 24, 2024

Conversation

reidsunderland
Copy link
Member

@reidsunderland reidsunderland commented May 22, 2024

The explanation is in #1064

Copy link

github-actions bot commented May 22, 2024

Test Results

244 tests   235 ✅  18s ⏱️
  1 suites    8 💤
  1 files      1 ❌

For more details on these failures, see this check.

Results for commit 3920fca.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@petersilva petersilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@petersilva
Copy link
Contributor

So... I'm not sure when... but sometime... I changed the credentials so that the password is never in the key...
and since then the anybody trying to run tests with user:pw url combos fail. It's fixed in #1067

@petersilva petersilva merged commit a6ffe07 into development May 24, 2024
2 of 4 checks passed
@petersilva petersilva deleted the issue1064 branch June 6, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants