Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update time window configuration #60

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Update time window configuration #60

merged 3 commits into from
Dec 7, 2023

Conversation

ctgh
Copy link
Contributor

@ctgh ctgh commented Nov 8, 2023 •
edited
Loading

Description

Update the configuration of the assimilation time window.

Yaml changes

The new yaml configuration is as follows:

time window:
  begin: <start datetime>
  length|end: <length|end datetime>
  bound to include: <begin|end (default)>

All yaml files were changed using the script shown in the accompanying oops PR.

Dependencies

Coordinate merge required with JCSDA-internal/oops/pull/2442

ctest output

Link to ctest output

@ctgh ctgh requested a review from twsearle November 21, 2023 10:06
twsearle
twsearle approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@twsearle twsearle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me!

@twsearle twsearle merged commit eb29fb8 into develop Dec 7, 2023
2 checks passed
@twsearle twsearle deleted the feature/time_window_config branch December 7, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twsearle twsearle twsearle approved these changes

Assignees
No one assigned
Labels
coordinate merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctgh @twsearle