Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci container #117

Merged

Conversation

twsearle
Copy link
Collaborator

@twsearle twsearle commented Sep 23, 2024

Description

Fixes to the underlying CI container to incorporate qhull as well as adding vader to the ci workflow. (both are requirements for building saber).

This change ought to be capable of getting saber built and tested. So far my workflow run on this only gives me a failure on the coding norms test:

The following tests FAILED:
	  1 - test_orcajedi_coding_norms (Failed)
Errors while running CTest

@twsearle twsearle self-assigned this Sep 23, 2024
@twsearle twsearle marked this pull request as ready for review September 23, 2024 09:28
@twsearle twsearle requested a review from frld September 23, 2024 09:28
@frld
Copy link
Contributor

frld commented Sep 24, 2024

Looks good thanks for sorting this. (I'll admit the coding norms are my fault which I'll sort).

Copy link
Contributor

@frld frld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much appreciated.

@frld frld merged commit 52ea581 into feature/add_simple_dirac_3dvar Sep 24, 2024
1 check passed
@twsearle twsearle deleted the feature/add_simple_dirac_3dvar-ci branch September 24, 2024 09:05
twsearle added a commit that referenced this pull request Oct 10, 2024
)

* Add 3DVar and error covariance toolbox (dirac test) main programs.
* Add interpolator increment apply and adjoint methods and add increment to
state method. 
* Update ci container (#117)
* Add reference data for 3dvar and dirac application tests. Turn off
creation of json schema again for 3dvar and errorcovariancetoolbox
applications.

Co-authored-by: Toby Searle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants