Use my credentials to store and retrieve container #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twsearle
force-pushed
the
feature/use-personal-ghcr-container
branch
from
d18ac7b
to
6f57e81
Compare
twsearle
force-pushed
the
feature/use-personal-ghcr-container
branch
from
dc66239
to
8caa2c1
Compare
twsearle
changed the title
yaswant
reviewed
Aug 1, 2024
Comment on lines
76
to
77
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
There was a problem hiding this comment.
Congratulations @twsearle 👍🏽
Just being picky really, will it be better to have some sensible tag and label for the image? like :
There was a problem hiding this comment.
The tags and labels are automatically generated from the docker metadata action. Its all still annoyingly chicken and egg! But I am hoping after I merge this I can version the tags the next PR.
yaswant
approved these changes
Aug 1, 2024
|
Also, you might want to protect the |
|
[like] Yaswant Pradhan reacted to your message:
________________________________
From: Toby Searle ***@***.***>
Sent: Thursday, August 1, 2024 12:36:26 PM
To: MetOffice/orca-jedi ***@***.***>
Cc: Yaswant Pradhan ***@***.***>; Review requested ***@***.***>
Subject: Re: [MetOffice/orca-jedi] Use my credentials to store and retrieve container (PR #113)
This email was received from an external source. Always check sender details, links & attachments.
@twsearle commented on this pull request.
________________________________
In .github/workflows/build_ci_image.yml<#113 (comment)>:
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}
The tags and labels are automatically generated from the docker metadata action<https://github.com/docker/metadata-action>. Its all still annoyingly chicken and egg! But I am hoping after I merge this I can version the tags the next PR.
—
Reply to this email directly, view it on GitHub<#113 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWYT6C4MGBXLKJD4LXBQRTZPITUVAVCNFSM6AAAAABLZ5YMFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJSGYYDENRZHA>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE This is a temporary fix to the CI to get us past the atlas upgrade. I will help refactor this to use a centralised solution when possible if desired.
Rather than use a persistent GitHub PAT for CI, I experimented to use each users ephemeral GITHUB_TOKEN, which is automatically generated and has a lifetime for only the life of the github workflow run. This is safer, and also gets around us needing more permissions on the darth account to create packages. However, it didn't work on this repo. I am not sure why, but authentication did not work.
Resolves #111