Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor documentation update for #277. #284

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

hiker
Copy link
Collaborator

@hiker hiker commented Mar 6, 2024

Minor documentation fixes for #277. It additionally fixes all other broken links reported (I had to guess a bit where the 'advanced c code' link was supposed to go - please let me know if not to the pragma injector section.).

Fixes #277.

Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, just one minor grammatical quibble.

I can't see a better place for the "advanced C" link to point to but the target is a bit thin. Nevermind.

step, where you can explicitly control how long to keep prebuild files.
This may be useful, for example, if you often switch between two versions
of your code and want to keep the prebuild speed benefits when building
both. If you do not add your own cleanup_prebuild step, Fab will
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a second paragraph.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hiker
Copy link
Collaborator Author

hiker commented Mar 17, 2024

Ready for next review.

Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to go on trunk.

@MatthewHambley MatthewHambley merged commit b86187e into MetOffice:master Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Documentation Update
2 participants