Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero config #226

Merged
merged 18 commits into from
Feb 24, 2023
Merged

zero config #226

merged 18 commits into from
Feb 24, 2023

Conversation

bblay
Copy link
Contributor

@bblay bblay commented Feb 10, 2023

First version of zero config command line tool.

Usage:

$ fab
$ fab <folder>

automatically found the following programs to build: second, first

Tested on:

  • some system test projects
    • FortranDependencies
    • CFortranInterop

So far, only tested using gfortran. That needs a linker flag, -lgfortran. We should try it with ifort, too. There might be a few linker flags we'll want to add to cover a wide variety of use cases.

todo:

  • test it with other stuff
  • test it with ifort

source/fab/cli.py Outdated Show resolved Hide resolved
@MatthewHambley MatthewHambley self-requested a review February 20, 2023 10:29
Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see movement on this mode of operation. This looks like a good starting point for further development.

source/fab/cli.py Show resolved Hide resolved
source/fab/cli.py Show resolved Hide resolved
source/fab/cli.py Outdated Show resolved Hide resolved
source/fab/cli.py Show resolved Hide resolved
source/fab/cli.py Show resolved Hide resolved
source/fab/steps/compile_fortran.py Show resolved Hide resolved
source/fab/steps/compile_fortran.py Show resolved Hide resolved
source/fab/steps/compile_fortran.py Show resolved Hide resolved
tests/unit_tests/steps/test_compile_fortran.py Outdated Show resolved Hide resolved
@bblay bblay requested a review from MatthewHambley February 22, 2023 12:49
@bblay
Copy link
Contributor Author

bblay commented Feb 22, 2023

Just noticed a todo I'd put at the top, to test with ifort. Will do that.

Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more bits of tidying up.

source/fab/steps/compile_fortran.py Show resolved Hide resolved
tests/unit_tests/steps/test_compile_fortran.py Outdated Show resolved Hide resolved
tests/unit_tests/steps/test_compile_fortran.py Outdated Show resolved Hide resolved
tests/unit_tests/steps/test_compile_fortran.py Outdated Show resolved Hide resolved
@bblay bblay requested a review from MatthewHambley February 24, 2023 12:22
MatthewHambley
MatthewHambley previously approved these changes Feb 24, 2023
Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time to bring this to trunk.

# Conflicts:
#	envs/docker/Dockerfile
#	source/fab/steps/analyse.py
#	tests/unit_tests/steps/test_compile_fortran.py
Copy link
Collaborator

@MatthewHambley MatthewHambley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge changes as expected.

@MatthewHambley MatthewHambley merged commit 22934a7 into MetOffice:master Feb 24, 2023
@bblay bblay deleted the zero_config branch February 24, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants