Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Testing upper and lower dependency version bounds via CI #54

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

cpelley
Copy link
Collaborator

@cpelley cpelley commented Aug 29, 2024

We need to ensure we test the lower bound set of packages as well as the complete set of unpinned packages through CI. This allows us to ensure that dagrunner can be used within environments that cover this range.
Clearly this isn't testing all possible combinations and instead reflects a reasonable attempt to indicate that dagrunner will function with these upper and lower range of package versions.

image

Additionally:

  • Removes unnecessary pip cache step (python-setup action which we use has built-in support for pip cache, see here).
  • Updated python version badge for the README.md to reflect dagrunner python version support (Python Project).

Issues

@cpelley cpelley self-assigned this Aug 29, 2024
@cpelley cpelley force-pushed the ci_matrix branch 2 times, most recently from 285c99c to 2ce22cc Compare August 29, 2024 11:42
@MetOffice MetOffice deleted a comment from github-actions bot Aug 29, 2024
@cpelley cpelley changed the title matrix package version TEST: Testing lower bound packages and unpinned packages Aug 29, 2024
@cpelley cpelley added the test label Aug 29, 2024
@cpelley cpelley changed the title TEST: Testing lower bound packages and unpinned packages TEST: Testing upper and lower bound package versions via CI Aug 29, 2024
@cpelley cpelley changed the title TEST: Testing upper and lower bound package versions via CI TEST: Testing upper and lower dependency version bounds via CI Aug 29, 2024
Copy link

@SamGriffithsMO SamGriffithsMO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New action is running and picking up different versions of dask and networkx

@cpelley cpelley merged commit 1b07e24 into main Aug 29, 2024
3 checks passed
@cpelley cpelley deleted the ci_matrix branch August 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants