-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parsing block_states with version greater than 1.18 #17
base: main
Are you sure you want to change the base?
Conversation
Thank you, this is such a welcome contribution! Btw, is the difference only in the capitalization of names ( If not, I'd prefer the old function to remain intact, possibly provisionally renamed as In the future, if desired, |
Also, would you mind adding a "Fix #10" suffix to the commit message so that bug is properly closed and linked to this fix? |
Thanks, I would try your suggestion to make backward compatible and update suffix. About difference, it is not the only capitalization, base on my experiment on 1.21 and wiki description, the different is:
|
- Upgrade supportting parsing version to 1.21 - Fix '_decode_blockstates' if palette number greater than 16
When is this getting merged? I would love to see this implemented, as there are currently no working MC world manipulation python libraries. |
Because that the index of palette array begins from 0, so the maximux index is 1 less than palette length
I didn't have the time to properly review or test it yet. The new block state format changes more than just renaming/reorganizing keys in the NBT structure, and this PR also deals with backward-compatibility at run time, so not very trivial. If anyone can/wants to test this, or even step up as a co-maintainer of this project, I would appreciate! |
Fix relate issue: #10, cite: https://minecraft.wiki/w/Chunk_format
But in contrast, this pr will cause that deprecating the support for old versions. So maybe creating a new branch is a better idea?