Upgrade Spring boot to 2.0.2.RELEASE and spring security to 2.3.3.RELEASE #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mert-Z
reviewed
Sep 27, 2018
| @@ -24,4 +24,6 @@ build/ | |||
| nbbuild/ | |||
| dist/ | |||
| nbdist/ | |||
| .nb-gradle/ | |||
There was a problem hiding this comment.
This will be automatically fixed for you when you do a git pull.
Mert-Z
reviewed
Sep 27, 2018
| @@ -0,0 +1 @@ | |||
| rootProject.name = 'spring-oauth2-cassandra-token-store' | |||
Mert-Z
reviewed
Sep 27, 2018
| @@ -28,7 +28,7 @@ | |||
|
|
|||
| @Override | |||
| public SchemaAction getSchemaAction() { | |||
| return SchemaAction.CREATE_IF_NOT_EXISTS; | |||
| return SchemaAction.RECREATE; | |||
There was a problem hiding this comment.
This can be problematic for a rolling upgrade. Shouldn't we keep the existing tokens in the DB since we are not altering DB schema?
|
Just a side note; it would also be nice to use new Cassandra 3.x materialised views instead of data duplication. That will avoid so many inserts on multiple tables and decrease the risk of having stale/unsync data between tables. On the other hand this will require migration of existing data to the new schema which can be costly. Can be done in a future story may be. :) |
Mert-Z
reviewed
Oct 25, 2018
|
|
||
| version = '0.0.1-SNAPSHOT' | ||
| group = 'mertz.security' |
There was a problem hiding this comment.
group = 'com.github.mert-z'
This will be automatically fixed for you when you do a git pull.
|
Nice one! Loved Java8 features.
Please do a git pull and then address the comments in PR so that I can
release it as v2 :)
…On Mon, Sep 17, 2018 at 10:34 PM danapsimer ***@***.***> wrote:
Upgrading to the latest spring boot and latest spring security brings with
it significant changes to spring-data-cassandra. This PR represents changes
to keep the implementation largely the same while accommodating the changes
in API.
------------------------------
You can view, comment on, or merge this pull request online at:
#8
Commit Summary
- added settings to allow releasing as a library
- upgraded code to work with latest spring boot, spring data, and
cassandra driver
File Changes
- *M* build.gradle
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-0>
(9)
- *A* settings.gradle
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-1>
(1)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/CassandraTokenStore.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-2>
(292)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/AccessToken.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-3>
(4)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/Authentication.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-4>
(6)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/AuthenticationToAccessToken.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-5>
(5)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/ClientIdToAccessToken.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-6>
(6)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/RefreshToken.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-7>
(6)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/RefreshTokenAuthentication.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-8>
(6)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/RefreshTokenToAccessToken.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-9>
(5)
- *M*
src/main/java/mertz/security/oauth2/provider/token/store/cassandra/model/UsernameToAccessToken.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-10>
(7)
- *M*
src/test/java/mertz/security/oauth2/provider/token/store/cassandra/CassandraTokenStoreTests.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-11>
(21)
- *M*
src/test/java/mertz/security/oauth2/provider/token/store/cassandra/EmbeddedCassandraTokenStoreTests.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-12>
(3)
- *M*
src/test/java/mertz/security/oauth2/provider/token/store/cassandra/cfg/CassandraConfig.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-13>
(6)
- *M*
src/test/java/org/springframework/security/oauth2/provider/token/store/TokenStoreBaseTests.java
<https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8/files#diff-14>
(7)
Patch Links:
-
https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8.patch
-
https://github.com/Mert-Z/spring-oauth2-cassandra-token-store/pull/8.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATEUPcf1o483jhVM3Ukv90x8W74XBL8rks5ucBVJgaJpZM4Wsw6a>
.
--
-------------------------------------------------------
Mert ZEYBEKLER
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to the latest spring boot and latest spring security brings with it significant changes to spring-data-cassandra. This PR represents changes to keep the implementation largely the same while accommodating the changes in API.