Measurement Tool

[VitorVieiraZ]

Measurement Tool

RPReplay_Final1727370214.3.1.mov

Enhancements to existing Mergin Maps Components:

• MMDrawer: Added support for a top-left button with an optional icon.
• Added support for area formatting in project units within Utils.
• MMButton now offers size options: Regular (traditional mode) and Small (used in the measurement tool).
• MMMapHidingLabel (used in showInfoTextMessage in MMMapController) now supports at most three lines.

Resolves #1400

[github-actions]

Pull Request Test Coverage Report for Build 11441167335

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 488 unchanged lines in 3 files lost coverage.
• Overall coverage increased (+0.3%) to 60.469%

---

Files with Coverage Reduction	New Missed Lines	%
input/app/mmstyle.h	56	1.95%
input/app/main.cpp	85	32.65%
input/app/inpututils.cpp	347	51.67%

Totals
Change from base Build 11327048776:	0.3%
Covered Lines:	7884
Relevant Lines:	13038

---

💛 - Coveralls

[PeterPetrik]

LGTM

[tomasMizera]

Where do you handle the done button? (from the cpp perspective)

[tomasMizera]

Please merge master here so the iOS is running :)

[tomasMizera]

Quite a few comments, but they are rather small. Thanks for addressing my previous ones!

[tomasMizera]

🚀

[tomasMizera]

Hi @uclaros, can I ask you to review the usage of QGIS API please? Thanks! You will find it in measurementmaptool.cpp/h

[erpas]

When you measure a line (not a closed shape) it still says it is Perimeter instead of just Length

[VitorVieiraZ]

When you measure a line (not a closed shape) it still says it is Perimeter instead of just Length

Hi @erpas, thanks for the comment. That’s the expected behavior following the tool design

[uclaros]

Nice work!
I've got a few comments though :)

• I'd also like to have the units selectable in the measurements panel. While the project default units is a good default start, I can see users wanting to change that temporarily for a single measurement)
• It would be nice to have 2 decimal digits when the measured distance is small enough (less than a meter? 10 meter? other?)
• It would be nice if there was a button to toggle closing/opening the geometry. If a user is trying to measure the area of a big square field, we shouldn't force him to re-digitize the first point in order to get an area! It would be way easier to just hit a button after digitizing the 3rd point.

[tomasMizera]

Looks good to me! Let me remove the changes to the android CI job