Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photo editor fixes #3459

Merged
merged 2 commits into from
May 27, 2024
Merged

Photo editor fixes #3459

merged 2 commits into from
May 27, 2024

Conversation

tomasMizera
Copy link
Collaborator

@tomasMizera tomasMizera commented May 24, 2024

Fixes #3405

Also hides the texts for input when the editor is empty and the form is read-only

Empty state - editable Empty state - readonly
image image

The resolution for #3405:

  • we were checking the state of QML Image component when setting its source -> this is wrong as the last state should not have any impact on the new source that is to be set. Not sure why we were doing that, but this should fix it now.

@tomasMizera tomasMizera requested a review from VitorVieiraZ May 24, 2024 10:00
Copy link

Pull Request Test Coverage Report for Build 9222144459

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.906%

Totals Coverage Status
Change from base Build 9209557888: 0.0%
Covered Lines: 7662
Relevant Lines: 12790

💛 - Coveralls

@tomasMizera tomasMizera merged commit 1c82014 into master May 27, 2024
12 checks passed
@tomasMizera tomasMizera deleted the photo-editor-fixes branch May 27, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not possible to edit a photo field in a form if the photo is missing
3 participants