Fixes after editors rework 2

app/qml/components/private/MMBaseInput.qml

@@ -94,6 +94,8 @@ Item {
       width: parent.width
       implicitHeight: titleRowGroup.implicitHeight
 
+      visible: root.title
+
       RowLayout {
         id: titleRowGroup
 

app/qml/components/private/MMBaseSingleLineInput.qml

@@ -48,7 +48,11 @@ MMBaseInput {
     return __style.forestColor
   }
 
+  // Text edited signal is emitted when user edits the text manually,
+  // you won't receive it when text is changed programatically.
+  // Use textChanged if you need to listen to any text change.
   signal textEdited( string text )
+
   signal textClicked()
   signal leftContentClicked()
   signal rightContentClicked()

app/qml/form/components/photo/MMPhotoPreview.qml

@@ -32,26 +32,37 @@ Popup {
 
     MMComponents.MMBusyIndicator {
       anchors.centerIn: parent
-      visible: true
+      visible: imagePreview.status === Image.Loading
+    }
+
+    // Do not propagate clicks to the background
+    MouseArea {
+      anchors.fill: parent
+      onClicked: function( mouse ) {
+        mouse.accepted = true
+      }
     }
 
     Item {
       id: photoFrame
 
-      anchors.centerIn: parent
       width: Math.min(imagePreview.width, parent.width)
       height: Math.min(imagePreview.height, parent.height)
 
+      y: parent.height / 2 - height / 2
+      x: parent.width / 2 - width / 2
+
       Image {
         id: imagePreview
 
         height: root.height / 2
 
-        autoTransform: true
+        clip: true
+
         focus: true
         asynchronous: true
+        autoTransform: true
         fillMode: Image.PreserveAspectFit
-      }
 
       PinchHandler {
         minimumRotation: -180
@@ -61,28 +72,22 @@ Popup {
       }
 
       DragHandler { }
+      }
     }
 
-    Item {
-      x: __style.safeAreaLeft
-      y: __style.safeAreaTop
-      width: parent.width - __style.safeAreaLeft - __style.safeAreaRight
-      height: parent.height - __style.safeAreaBottom - __style.safeAreaTop
-
-      MMComponents.MMRoundButton {
-        id: closeButton
-
-        anchors {
-          horizontalCenter: parent.horizontalCenter
-          bottom: parent.bottom
-          bottomMargin: __style.spacing20
-        }
-
-        bgndColor: __style.lightGreenColor
-        iconSource: __style.closeIcon
-        onClicked: {
-          previewLoader.active = false
-        }
+    MMComponents.MMRoundButton {
+      id: closeButton
+
+      anchors {
+        horizontalCenter: parent.horizontalCenter
+        bottom: parent.bottom
+        bottomMargin: __style.safeAreaBottom + __style.spacing20
+      }
+
+      bgndColor: __style.lightGreenColor
+      iconSource: __style.closeIcon
+      onClicked: {
+        previewLoader.active = false
       }
     }
   }

app/qml/form/editors/MMFormCalendarEditor.qml

@@ -64,6 +64,8 @@ MMPrivateComponents.MMBaseSingleLineInput {
     root.rememberValueBoxClicked( checkboxChecked )
   }
 
+  textField.readOnly: true
+
   onTextClicked: root.openCalendar()
   onRightContentClicked: root.openCalendar()
 

app/qml/inputs/MMComboboxInput.qml

@@ -34,6 +34,8 @@ MMPrivateComponents.MMBaseSingleLineInput {
   onTextClicked: { drawerLoader.active = true; drawerLoader.focus = true }
   onRightContentClicked: { drawerLoader.active = true; drawerLoader.focus = true }
 
+  textField.readOnly: true
+
   text: {
     if ( !comboboxModel ) return "";
     if ( currentIndex < 0 || currentIndex >= comboboxModel.count ) return "";

app/qml/map/MMMapController.qml

@@ -276,22 +276,6 @@ Item {
     sourceComponent: stakeoutToolsComponent
   }
 
-  MMPositionMarker {
-    id: positionMarker
-
-    xPos: mapPositionSource.screenPosition.x
-    yPos: mapPositionSource.screenPosition.y
-    hasDirection: positionDirectionSource.hasDirection
-
-    direction: positionDirectionSource.direction
-    hasPosition: __positionKit.hasPosition
-
-    horizontalAccuracy: __positionKit.horizontalAccuracy
-    accuracyRingSize: mapPositionSource.screenAccuracy
-
-    trackingMode: root.state !== "inactive" && tracking.active
-  }
-
   Loader {
     id: tracking
 
@@ -348,6 +332,22 @@ Item {
     }
   }
 
+  MMPositionMarker {
+    id: positionMarker
+
+    xPos: mapPositionSource.screenPosition.x
+    yPos: mapPositionSource.screenPosition.y
+    hasDirection: positionDirectionSource.hasDirection
+
+    direction: positionDirectionSource.direction
+    hasPosition: __positionKit.hasPosition
+
+    horizontalAccuracy: __positionKit.horizontalAccuracy
+    accuracyRingSize: mapPositionSource.screenAccuracy
+
+    trackingMode: root.state !== "inactive" && tracking.active
+  }
+
   Loader {
     id: recordingToolsLoader
 
@@ -521,7 +521,7 @@ Item {
 
           text: {
             if (visible) {
-              return root.trackingManager?.elapsedTimeText
+              return root.trackingManager?.elapsedTimeText ?? ""
             }
             else
               return ""

app/qml/project/components/MMProjectWizardDelegate.qml

@@ -23,7 +23,7 @@ Item {
   signal removeClicked()
   signal attrNameChanged( string attrname )
 
-  implicitHeight: __style.row50
+  implicitHeight: row.implicitHeight
 
   RowLayout {
     id: row
@@ -36,18 +36,16 @@ Item {
     MMInputs.MMTextInput {
       id: textField
 
-      text: root.attrname
-
-      Layout.fillHeight: true
       Layout.fillWidth: true
 
-      onTextEdited: (text) => root.attrNameChanged( text )
+      text: root.attrname
+
+      onTextChanged: () => root.attrNameChanged( text )
     }
 
     MMInputs.MMComboboxInput {
       id: combobox
 
-      Layout.fillHeight: true
       Layout.fillWidth: true
     }
 

app/qml/settings/components/MMSettingsInput.qml

@@ -49,6 +49,8 @@ MMSettingsItem {
           MMInputs.MMTextInput {
             id: textInput
 
+            width: parent.width
+
             title: root.title
 
             textFieldBackground.color: __style.lightGreenColor