remove deprecated QGIS API for writeAsVectorFormatV2 #2874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1613
Replace deprecated QGIS API writeAsVectorFormatV2 with writeAsVectorFormatV3 (it has different position for error code in arguments)
also removed artificial call to
QgsVectorFileWriter::create
, it should not be used at all whenwriteAsVectorFormatV3
is used. This also removes bunch of warnings likeERROR 1: sqlite3_exec ...
visible on desktop from the initial implementation #1103https://github.com/qgis/QGIS/blob/1f1e8b5de70a8a1c1e6a639f08fd15b9aeea6f8b/src/core/qgsvectorfilewriter.h#L663