Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Qt.inputMethod.commit() for tests #2804

Closed
wants to merge 1 commit into from

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Sep 25, 2023

Just for tests, if it is needed to use Qt.inputMethod.commit() method

@iiLubos iiLubos requested a review from tomasMizera September 25, 2023 13:56
@tomasMizera
Copy link
Collaborator

@jozef-budac / @PatrikMizera, can we please test text and number inputs? We need to test different keyboards as well. The goal is to see if everything is working fine as previously (e.g. form validations)

@tomasMizera tomasMizera added the ready-for-testing Ready to be tested by testers crew - passed review by devs label Sep 25, 2023
@jozef-budac
Copy link

jozef-budac commented Sep 25, 2023

TI @tomasMizera . I have tested on Android 11, 13, and iOS and on iOS keyboard, Gboad, and Samsung keyboard and found nothing problematic. Everything worked ok.

The test scenarios were:

  • different input widgets
  • validation on decimal numbers
  • validation with constraints

@jozef-budac
Copy link

I just found one problem with relations. The app freezes when you create a parent and from it the child.
Scenario:

  1. Open project tc05_relations
  2. Hit record on the district, add 3 points, and hit done so the form opens
  3. Write a name on the form
  4. Hit +Add to add a child. On the map add 3 points and hit Done -> the app freezes

Screen recording:
https://drive.google.com/file/d/1lZa8aZelJV1xNAxHCXUJmB9W-Hr0pyOR/view?usp=sharing

@PeterPetrik PeterPetrik added the FROZEN 🥶 do not merge before upcoming release label Oct 5, 2023
@PeterPetrik PeterPetrik removed the FROZEN 🥶 do not merge before upcoming release label Oct 24, 2023
@tomasMizera
Copy link
Collaborator

This change seems very dangerous atm. We will revisit within redesign

@PeterPetrik PeterPetrik deleted the master_inputMethodCommit branch March 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing Ready to be tested by testers crew - passed review by devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants