Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gallery: basic model/view for notifications #2765

Closed
wants to merge 2 commits into from

Conversation

iiLubos
Copy link
Contributor

@iiLubos iiLubos commented Aug 22, 2023

No description provided.

@iiLubos iiLubos requested a review from tomasMizera August 22, 2023 21:01
@PeterPetrik
Copy link
Contributor

can we setup base branch master? dev-2.3 is deprecated and should be removed. @tomasMizera

Item {
id: control

z: 100
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

z

Rectangle {
anchors.bottom: parent.bottom
width: control.width
height: 20
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From style

@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Sep 27, 2023
@PeterPetrik
Copy link
Contributor

can we rebase and change target branch to master?


picture: Style.uploadImage
title: "Failed to synchronize your changes"
description: "Your changes could not be sent to server, make sure you are connected to internet and have write access to this project."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these needs to be tr()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think no, Gallery app is only for our purpose. Not need to translate. We just want to see how it will look like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right

@iiLubos iiLubos closed this Oct 6, 2023
@PeterPetrik PeterPetrik deleted the redesign_notification branch March 20, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FROZEN 🥶 do not merge before upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants