fix mapcanvas memory leak

MerginMaps · Aug 31, 2023 · c2aa30a · c2aa30a · inputapp-bot · Aug 31, 2023
1 parent 6345f19
commit c2aa30a
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/app/map/inputmapcanvasmap.cpp b/app/map/inputmapcanvasmap.cpp
@@ -55,7 +55,10 @@ InputMapCanvasMap::InputMapCanvasMap( QQuickItem *parent )
   setFlags( QQuickItem::ItemHasContents );
 }
 
-InputMapCanvasMap::~InputMapCanvasMap() = default;
+InputMapCanvasMap::~InputMapCanvasMap()
+{
+  stopRendering();
+}
 
 InputMapSettings *InputMapCanvasMap::mapSettings() const
 {
@@ -438,9 +441,16 @@ void InputMapCanvasMap::stopRendering()
 {
   if ( mJob )
   {
+    mMapUpdateTimer.stop();
+
     disconnect( mJob, &QgsMapRendererJob::renderingLayersFinished, this, &InputMapCanvasMap::renderJobUpdated );
     disconnect( mJob, &QgsMapRendererJob::finished, this, &InputMapCanvasMap::renderJobFinished );
 
+    if ( !mJob->isActive() )
+      mJob->deleteLater();
+    else
+      connect( mJob, &QgsMapRendererJob::finished, mJob, &QObject::deleteLater );
+
     mJob->cancelWithoutBlocking();
     mJob = nullptr;
   }