Simplify error and signal

MerginMaps · Nov 14, 2024 · 038fbfa · 038fbfa · inputapp-bot · Nov 14, 2024
1 parent a0e7157
commit 038fbfa
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/app/qml/main.qml b/app/qml/main.qml
@@ -867,6 +867,9 @@ ApplicationWindow {
           // just banner that we will try again
           __notificationModel.addInfo( qsTr( "Somebody else is syncing, we will try again later" ) )
         }
+        else if ( errorType === MM.SyncError.MonthlyContributorsLimitHit){
+          monthlyContributorsLimitDialog.open()
+        }
         else
         {
           syncFailedDialog.detailedText = qsTr( "Details" ) + ": " + errorMessage
@@ -882,10 +885,6 @@ ApplicationWindow {
         }
       }
     }
-
-    function onMonthlyContributorsLimitReached( uploadSize ) {
-      monthlyContributorsLimitDialog.open()
-    }
   }
 
   Connections {

diff --git a/app/synchronizationmanager.cpp b/app/synchronizationmanager.cpp
@@ -286,10 +286,6 @@ void SynchronizationManager::onProjectSyncFailure(
   }
   else
   {
-    if ( error == SynchronizationError::MonthlyContributorsLimitHit )
-    {
-      emit monthlyContributorsLimitReached( "" );
-    }
     mSyncProcesses.remove( projectFullName );
     emit syncFinished( projectFullName, false, -1, false );
 

diff --git a/app/synchronizationmanager.h b/app/synchronizationmanager.h
@@ -64,7 +64,6 @@ class SynchronizationManager : public QObject
     void syncFinished( const QString &projectFullName, bool success, int newVersion, bool reloadNeeded );
 
     void syncError( const QString &projectFullName, int errorType, bool willRetry = false, const QString &errorMessage = QLatin1String() );
-    void monthlyContributorsLimitReached( const QString &message );
 
   public slots: