Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneccessary guava dependency #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unneccessary guava dependency #27

wants to merge 1 commit into from

Conversation

wuan
Copy link
Collaborator

@wuan wuan commented May 27, 2020

Separated classes AlgorithmFactory and RSAKeyProviderFactory to enable testing.

@coveralls
Copy link

coveralls commented May 27, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 87.532% when pulling 501ea5e on wuan:cleanup_dependencies into 01b557f on Mercateo:master.

@wuan wuan force-pushed the cleanup_dependencies branch 4 times, most recently from b55ed10 to b5bba5d Compare May 27, 2020 11:47
@wuan
Copy link
Collaborator Author

wuan commented May 27, 2020

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
           

Complexity increasing per file
==============================
- src/test/java/com/mercateo/spring/security/jwt/token/verifier/AlgorithmFactoryTest.java  1
- src/main/java/com/mercateo/spring/security/jwt/token/verifier/AlgorithmFactory.java  5
- src/main/java/com/mercateo/spring/security/jwt/token/verifier/RSAKeyProviderFactory.java  1

See the complete overview on Codacy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuan @coveralls