-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SF2M Rewrite (1.8.0) #109
Open
Mentrillum
wants to merge
56
commits into
master
Choose a base branch
from
1-8-0-rewrite
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SF2M Rewrite (1.8.0) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Logo replaced * Add Korean Translation * Change some occurrences --------- Co-authored-by: Mentrillum <[email protected]>
Fixes "Invalid parameter number: 3" error.
Adds a native to get the current boss pack name.
OnPlayerRunCmd was updated with a IsValidClient which breaks AFK status for newly connected players.
* Mark natives as optional if library is not required * Fix AttackIndex native (sf2.inc) * Fix AttackIndex native (chaser/entity.sp) * Fix compilation error if DEBUG is not defined
* Update playsequenceandwait.sp Small Fix to Deathcam Bug * Update playsequenceandwait.sp Forget Something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the years Slender Fortress evolved and the younger Modified counterpart also evolved, but most of the code was touched in not so good ways and sub plugins are forced to be designed around this forced nature. The main purpose of this PR is to fully modularize SF2M's codebase. Features like the flashlight, ultravision, proxy system, and music system are now properly divided up into their own files rather than have each main file rely on parts of one system that is completely unrelated to it. To accomplish this SF2M now uses private forwards, which is the local equivalent to global forwards, these can be called and other files with static functions can fire once these forwards are called.
Along with the backend changes, there will be many changes that are QoL improvements for server owners or creators, there may not be as many player QoL changes except for bug fixes. Once everything is ready to go, the final update will ship.
If there is ANY bug you've seen and figured out how to trigger, submit it as a Github issue and add the label 1.8.0. Link is here https://github.com/Mentrillum/Slender-Fortress-Modified-Versions/issues
Goals
Changes
Known bugs