Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dgg chat steals input focus in Blink browsers when switching tabs #117

Open
JoannesJ opened this issue Nov 24, 2018 · 0 comments
Open

Dgg chat steals input focus in Blink browsers when switching tabs #117

JoannesJ opened this issue Nov 24, 2018 · 0 comments
Labels
bug external external dependency frontend

Comments

@JoannesJ
Copy link

Steps:

  • Open a stream with chat open
  • Load dgg chat on that stream
  • Switch back to sgg chat
  • Now switch to another browser tab and switch back
  • Observe how the input field on sgg chat has focus for a second or so but then loses it

This is caused by dgg chat requesting focus.
Firefox disallows focus on elements which are have visibility: hidden or display: none.
It seems this is not the case in Blink browsers when the focusing element is in an iframe.

Possible solution would be to unload/reload the dgg chat.
Not ideal, causing friction in switching between chats; although favoring sgg chat 😏
@kenany kenany added bug frontend external external dependency labels Nov 24, 2018
JoannesJ added a commit to JoannesJ/chat-gui that referenced this issue Feb 8, 2019
@JoannesJ
Patch dgg chat stealing focus issue (not a proper fix)
bb7fd36 
This addresses github.com/MemeLabs/Rustla2/issues/117
Not a proper fix, as typing in chat directly after switching will steal a few
characters mid sentence.
Though it's better than nothing, until we can implement a proper fix.
@JoannesJ JoannesJ mentioned this issue Feb 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug external external dependency frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kenany @JoannesJ