isuue: 1647751 Use burst info when setting rate limit with VMA #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-ivanov
reviewed
Mar 1, 2019
src/common.h
Outdated
|
|
||
| int sock_set_rate_limit(int fd, uint32_t rate_limit); | ||
|
|
||
| int sock_set_rate_limit(int fd, uint32_t rate_limit, uint32_t burst_packet_size, uint16_t pkt_size); |
There was a problem hiding this comment.
please consider default values for burst_packet_size and pkt_size to avoid unused variable issue.
igor-ivanov
reviewed
Mar 1, 2019
rafiw
force-pushed
the
add_pp_burst_info
branch
2 times, most recently
from
5c64f74
to
60897ba
Compare
Signed-off-by: Rafi Wiener <[email protected]>
|
bot:retest |
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafi Wiener [email protected]