issue: 1897191 Implement extra TCP statistics #870
Conversation
|
Test PASSed. |
|
Test FAILed. |
|
Test PASSed. |
|
|
||
| typedef struct socket_tcp_stats socket_tcp_stats_t; | ||
|
|
||
| #define EXTRA_STATS_INC(x) ++x |
There was a problem hiding this comment.
please consider (++x)
|
Possible improvement:
|
VMA doesn't provide enough information to investigate TCP bottlenecks. Collect more counters and metrics for a TCP connection and integrate them into vma_stats. This statistics will help to see internals and describe TCP behavior. Signed-off-by: Dmytro Podgornyi <[email protected]>
- Revert changes to stats_publisher and stats_data_reader. Instead, modify the stats directly in m_p_socket_stats via a pointer. This saves 1 copy operation per tick. - Move modification of the retransmit counters to a separate private method. The motivation is to reduce copy-paste and create a common execution path for both TSO and no-TSO builds. It won't require to check both builds for test coverage. Signed-off-by: Dmytro Podgornyi <[email protected]>
|
Test FAILed. |
|
Test PASSed. |
| @@ -132,6 +170,8 @@ tcp_tmr(struct tcp_pcb* pcb) | |||
| tcp_tmr() is called. */ | |||
| tcp_slowtmr(pcb); | |||
| } | |||
|
|
|||
| copy_tcp_metrics(pcb); | |||
There was a problem hiding this comment.
Please consider
#ifdef DEFINED_EXTRA_STATS
#endif /* DEFINED_EXTRA_STATS */
as is done in other places
| @@ -312,6 +312,9 @@ class sockinfo_tcp : public sockinfo, public timer_handler | |||
| inline void unlock_tcp_con(); | |||
| void tcp_timer(); | |||
|
|
|||
| // Increment retransmit counters | |||
| void on_retransmit(); | |||
There was a problem hiding this comment.
function is not big you can consider inlining
| if (m_pcb.cwnd < m_pcb.ssthresh) | ||
| EXTRA_STATS_INC(m_pcb.p_stats->n_rtx_ss); | ||
| } | ||
|
|
There was a problem hiding this comment.
there is only place where attribute VMA_TX_PACKET_REXMIT = TCP_WRITE_REXMIT is set as
Line 1751 in 7211589
so consider collection this parameter from new lwip internal statistic structure.
It allows to reduce code below.
| #ifdef DEFINED_EXTRA_STATS | ||
| /* Set pointer to extra TCP stats instance */ | ||
| void register_tcp_stats_instance(struct tcp_pcb *pcb, socket_tcp_stats_t *stats); | ||
| #endif /* DEFINED_EXTRA_STATS */ |
There was a problem hiding this comment.
register_ notation is for global function mostly related vma_lwip() initialization.
I would suggest to name as tcp_stats()
| else | ||
| AC_MSG_RESULT([no]) | ||
| fi | ||
|
|
There was a problem hiding this comment.
please consider moving to config\m4\opt.m4.
Look to implementation of otional log configure option at https://github.com/Mellanox/libvma/blob/master/config/m4/opt.m4
I would like to suggest --enable-opt-stats with following values:
no | none)
;;
medium)
;;
high)
;;
*)
Probably it can be done w/o none at this pull request
|
Can one of the admins verify this patch? |
VMA doesn't provide enough information to investigate TCP bottlenecks.
Collect more counters and metrics for a TCP connection and integrate
them into vma_stats. This statistics will help to see internals and
describe TCP behavior.
Signed-off-by: Dmytro Podgornyi [email protected]