issue: 3465282 Fix IB clock converter inaccuracy #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid value for hca core clock frequency was used in time_converter_ib_ctx::calculate_delta. Signed-off-by: Alexander Galanin <[email protected]>
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use proper multiplier while converting HCA core clock frequency into Hz.
What
Fix IB clock converter inaccuracy
Why ?
Invalid value for hca core clock frequency was used in time_converter_ib_ctx::calculate_delta.
How ?
We used hca_core_clock for clock conversion from HW timestamp to system clock. But the value for hca_core_clock variable is converted from device capabilities as it's in MHz (multiplied to 1000000=USEC_PER_SEC). That's look wrong because ibv_device_attr_ex.hca_core_clock is in Khz.
Change type
What kind of change does this PR introduce?
Check list